There is a vulnerability in DL and Fiddle in Ruby where tainted strings can be
used by system calls regardless of the $SAFE level set in Ruby. This
vulnerability has been assigned the CVE identifier CVE-2013-2065.

## Impact

Native functions exposed to Ruby with DL or Fiddle do not check the taint
values set on the objects passed in.  This can result in tainted objects being
accepted as input when a SecurityError exception should be raised.

Impacted DL code will look something like this:

<figure class="highlight"><pre><code class="language-ruby" data-lang="ruby"><span class="k">def</span> <span class="nf">my_function</span><span class="p">(</span><span class="n">user_input</span><span class="p">)</span>
  <span class="n">handle</span>    <span class="o">=</span> <span class="no">DL</span><span class="p">.</span><span class="nf">dlopen</span><span class="p">(</span><span class="kp">nil</span><span class="p">)</span>
  <span class="n">sys_cfunc</span> <span class="o">=</span> <span class="no">DL</span><span class="o">::</span><span class="no">CFunc</span><span class="p">.</span><span class="nf">new</span><span class="p">(</span><span class="n">handle</span><span class="p">[</span><span class="s1">'system'</span><span class="p">],</span> <span class="no">DL</span><span class="o">::</span><span class="no">TYPE_INT</span><span class="p">,</span> <span class="s1">'system'</span><span class="p">)</span>
  <span class="n">sys</span>       <span class="o">=</span> <span class="no">DL</span><span class="o">::</span><span class="no">Function</span><span class="p">.</span><span class="nf">new</span><span class="p">(</span><span class="n">sys_cfunc</span><span class="p">,</span> <span class="p">[</span><span class="no">DL</span><span class="o">::</span><span class="no">TYPE_VOIDP</span><span class="p">])</span>
  <span class="n">sys</span><span class="p">.</span><span class="nf">call</span> <span class="n">user_input</span>
<span class="k">end</span>

<span class="vg">$SAFE</span> <span class="o">=</span> <span class="mi">1</span>
<span class="n">my_function</span> <span class="s2">"uname -rs"</span><span class="p">.</span><span class="nf">taint</span></code></pre></figure>

Impacted Fiddle code will look something like this:

<figure class="highlight"><pre><code class="language-ruby" data-lang="ruby"><span class="k">def</span> <span class="nf">my_function</span><span class="p">(</span><span class="n">user_input</span><span class="p">)</span>
  <span class="n">handle</span>    <span class="o">=</span> <span class="no">DL</span><span class="p">.</span><span class="nf">dlopen</span><span class="p">(</span><span class="kp">nil</span><span class="p">)</span>
  <span class="n">sys</span> <span class="o">=</span> <span class="no">Fiddle</span><span class="o">::</span><span class="no">Function</span><span class="p">.</span><span class="nf">new</span><span class="p">(</span><span class="n">handle</span><span class="p">[</span><span class="s1">'system'</span><span class="p">],</span>
                             <span class="p">[</span><span class="no">Fiddle</span><span class="o">::</span><span class="no">TYPE_VOIDP</span><span class="p">],</span> <span class="no">Fiddle</span><span class="o">::</span><span class="no">TYPE_INT</span><span class="p">)</span>
  <span class="n">sys</span><span class="p">.</span><span class="nf">call</span> <span class="n">user_input</span>
<span class="k">end</span>

<span class="vg">$SAFE</span> <span class="o">=</span> <span class="mi">1</span>
<span class="n">my_function</span> <span class="s2">"uname -rs"</span><span class="p">.</span><span class="nf">taint</span></code></pre></figure>

All users running an affected release should either upgrade or use one of the
workarounds immediately.

Note that this *does not* prevent numeric memory offsets from being used as
pointer values.  Numbers cannot be tainted, so code passing a numeric memory
offset cannot be checked.  For example:

<figure class="highlight"><pre><code class="language-ruby" data-lang="ruby"><span class="k">def</span> <span class="nf">my_function</span><span class="p">(</span><span class="n">input</span><span class="p">)</span>
  <span class="n">handle</span>    <span class="o">=</span> <span class="no">DL</span><span class="p">.</span><span class="nf">dlopen</span><span class="p">(</span><span class="kp">nil</span><span class="p">)</span>
  <span class="n">sys</span> <span class="o">=</span> <span class="no">Fiddle</span><span class="o">::</span><span class="no">Function</span><span class="p">.</span><span class="nf">new</span><span class="p">(</span><span class="n">handle</span><span class="p">[</span><span class="s1">'system'</span><span class="p">],</span>
                             <span class="p">[</span><span class="no">Fiddle</span><span class="o">::</span><span class="no">TYPE_VOIDP</span><span class="p">],</span> <span class="no">Fiddle</span><span class="o">::</span><span class="no">TYPE_INT</span><span class="p">)</span>
  <span class="n">sys</span><span class="p">.</span><span class="nf">call</span> <span class="n">input</span>
<span class="k">end</span>

<span class="vg">$SAFE</span> <span class="o">=</span> <span class="mi">1</span>
<span class="n">user_input</span> <span class="o">=</span> <span class="s2">"uname -rs"</span><span class="p">.</span><span class="nf">taint</span>
<span class="n">my_function</span> <span class="no">DL</span><span class="o">::</span><span class="no">CPtr</span><span class="p">[</span><span class="n">user_input</span><span class="p">].</span><span class="nf">to_i</span></code></pre></figure>

In this case, the memory location is passed, and taintedness of the object
cannot be determined by DL / Fiddle.  In this case, please check the tainting
of the user input before passing the memory location:

<figure class="highlight"><pre><code class="language-ruby" data-lang="ruby"><span class="n">user_input</span> <span class="o">=</span> <span class="s2">"uname -rs"</span><span class="p">.</span><span class="nf">taint</span>
<span class="k">raise</span> <span class="k">if</span> <span class="vg">$SAFE</span> <span class="o">&gt;=</span> <span class="mi">1</span> <span class="o">&amp;&amp;</span> <span class="n">user_input</span><span class="p">.</span><span class="nf">tainted?</span>
<span class="n">my_function</span> <span class="no">DL</span><span class="o">::</span><span class="no">CPtr</span><span class="p">[</span><span class="n">user_input</span><span class="p">].</span><span class="nf">to_i</span></code></pre></figure>

## Workarounds

If you cannot upgrade Ruby, this monkey patch can be used as a workaround:

<figure class="highlight"><pre><code class="language-ruby" data-lang="ruby"><span class="k">class</span> <span class="nc">Fiddle::Function</span>
  <span class="k">alias</span> <span class="ss">:old_call</span> <span class="ss">:call</span>
  <span class="k">def</span> <span class="nf">call</span><span class="p">(</span><span class="o">*</span><span class="n">args</span><span class="p">)</span>
    <span class="k">if</span> <span class="vg">$SAFE</span> <span class="o">&gt;=</span> <span class="mi">1</span> <span class="o">&amp;&amp;</span> <span class="n">args</span><span class="p">.</span><span class="nf">any?</span> <span class="p">{</span> <span class="o">|</span><span class="n">x</span><span class="o">|</span> <span class="n">x</span><span class="p">.</span><span class="nf">tainted?</span> <span class="p">}</span>
      <span class="k">raise</span> <span class="no">SecurityError</span><span class="p">,</span> <span class="s2">"tainted parameter not allowed"</span>
    <span class="k">end</span>
    <span class="n">old_call</span><span class="p">(</span><span class="o">*</span><span class="n">args</span><span class="p">)</span>
  <span class="k">end</span>
<span class="k">end</span></code></pre></figure>

## Affected versions

* All ruby 1.9 versions prior to ruby 1.9.3 patchlevel 426
* All ruby 2.0 versions prior to ruby 2.0.0 patchlevel 195
* prior to trunk revision 40728

ruby 1.8 versions are not affected.

## Credits

Thanks to Vit Ondruch for reporting this issue.

## History

* Originally published at 2013-05-14 13:00:00 (UTC)
